Remove support/donation for macOS FTP builds, as it's not supported outside of AppStore #1074
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1074 +/- ##
==========================================
- Coverage 38.31% 36.21% -2.11%
==========================================
Files 120 129 +9
Lines 6511 7542 +1031
==========================================
+ Hits 2495 2731 +236
- Misses 4016 4811 +795 ☔ View full report in Codecov by Sentry. |
@BPerlakiH Please open an issue for that asap, otherwise we will forget |
Actually, if the feature is not working, it has to be hidden. You can do that here in this PR. you should detect the way the app is compiled and act accordingly. |
BPerlakiH
changed the title
|
CI red |
|
Please merge this other PR first: #1076 |
kelson42
force-pushed
the
fix-cd-builds
branch
from
36c44e1 to
5446417
Compare
Fixes: #1055
Fix the CD process for macOS.
In short: the in-app-purchase is not supported by Developer ID signed apps (outside of the App Store), therefore we cannot use that capability in the FTP macOS build.
Although Apple Pay itself is supported, the In App Purchase capability that we use (for Donation - a purchase of a non-digital good) is not supported.
The found Apple reference:
https://developer.apple.com/help/account/reference/supported-capabilities-macos
We need a follow up discussion, if we want to hide the support button in this case or maybe use a direct link instead (since this build is not going to be verified by Apple).
After the comments, the approach is that we inject the
HIDE_DONATION: truekey/value into the Support/Info.plist file for macOS FTP builds. For all other builds the fallback value isfalse(do not hide). The condition whether to display the Support / Donation button is also dependent on the type of brand we run, therefore custom apps are not affected.